Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the reporter dynamic #19587

Merged
merged 1 commit into from
Oct 23, 2022
Merged

make the reporter dynamic #19587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/tasks/e2e-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ export const e2eTests: Task = {
return false;
},
async run({ codeDir, junitFilename, template }, { dryRun, debug }) {
const reporter = process.env.CI ? 'junit' : 'html';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we switch on junitFilename here?


await exec(
'yarn playwright test --reporter=junit',
`yarn playwright test --reporter=${reporter}`,
{
env: {
STORYBOOK_URL: `http://localhost:${PORT}`,
Expand Down