Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: Send start/build events even when there is no generator #19507

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

tmeasday
Copy link
Member

Issue: 'start' / 'build' events were not getting sent for the v6 store

What I did

Ensure we do.

Note this code need some kind of tests to avoid future regressions. Let's discuss.

@tmeasday tmeasday added bug patch:yes Bugfix & documentation PR that need to be picked to main branch telemetry labels Oct 17, 2022
@tmeasday tmeasday requested a review from shilman October 17, 2022 06:06
@shilman shilman changed the title Send start event event even when there is no generator Telemetry: Send start event event even when there is no generator Oct 17, 2022
@shilman shilman changed the title Telemetry: Send start event event even when there is no generator Telemetry: Send start/build events even when there is no generator Oct 17, 2022
@shilman shilman merged commit 53c74e7 into next Oct 17, 2022
@shilman shilman deleted the fix-v6-telemetry branch October 17, 2022 13:07
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 24, 2022
shilman added a commit that referenced this pull request Oct 24, 2022
Telemetry: Send start/build events even when there is no generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants