Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: Send start/build events even when there is no generator #19507

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Telemetry: Send start/build events even when there is no generator #19507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86ef55c
Send start event event even when there is no generator
tmeasday Oct 17, 2022
2abd054
Same for `'build'` event
tmeasday Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions code/lib/core-server/src/build-static.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,7 @@ export async function buildStaticStandalone(
if (!core?.disableTelemetry) {
effects.push(
initializedStoryIndexGenerator.then(async (generator) => {
if (!generator) {
return;
}

const storyIndex = await generator.getIndex();
const storyIndex = await generator?.getIndex();
const payload = storyIndex
? {
storyIndex: {
Expand Down
6 changes: 1 addition & 5 deletions code/lib/core-server/src/dev-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,7 @@ export async function storybookDevServer(options: Options) {

if (!core?.disableTelemetry) {
initializedStoryIndexGenerator.then(async (generator) => {
if (!generator) {
return;
}

const storyIndex = await generator.getIndex();
const storyIndex = await generator?.getIndex();
const payload = storyIndex
? {
storyIndex: {
Expand Down