-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Remove official-storybook #19343
Merged
shilman
merged 13 commits into
next
from
norbert/sb-702-migrate-stories-and-delete-official
Oct 11, 2022
Merged
Examples: Remove official-storybook #19343
shilman
merged 13 commits into
next
from
norbert/sb-702-migrate-stories-and-delete-official
Oct 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
changed the base branch from
next
to
norbert/sb-625-remove-cypress-from-the-monorepo
October 5, 2022 07:40
…orbert/sb-702-migrate-stories-and-delete-official
Base automatically changed from
norbert/sb-625-remove-cypress-from-the-monorepo
to
next
October 5, 2022 08:10
ndelangen
commented
Oct 5, 2022
I pushed a fix for the failing smoketest of
We're removing the example soon so I just wanted to do the minimal fix, which was to make Svelte ignore the a11y warnings. |
Followups:
|
shilman
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YOLO!!! Let's goooooo!!!! 🚀
shilman
deleted the
norbert/sb-702-migrate-stories-and-delete-official
branch
October 11, 2022 14:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove examples/official-storybook