Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Remove official-storybook #19343

Merged
merged 13 commits into from
Oct 11, 2022

Conversation

ndelangen
Copy link
Member

remove examples/official-storybook

@ndelangen ndelangen self-assigned this Oct 4, 2022
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Oct 4, 2022
@ndelangen ndelangen changed the base branch from next to norbert/sb-625-remove-cypress-from-the-monorepo October 5, 2022 07:40
…orbert/sb-702-migrate-stories-and-delete-official
Base automatically changed from norbert/sb-625-remove-cypress-from-the-monorepo to next October 5, 2022 08:10
README.md Show resolved Hide resolved
@ndelangen ndelangen marked this pull request as ready for review October 5, 2022 13:08
@ndelangen
Copy link
Member Author

This will have to be disabled:
Screen Shot 2022-10-05 at 15 21 51

... since this task will no longer be executed .

@JReinhold
Copy link
Contributor

I pushed a fix for the failing smoketest of svelte-kitchen-sink.

  • I don't know why it started failing now
  • I don't know why warnings would cause it to fail completely

We're removing the example soon so I just wanted to do the minimal fix, which was to make Svelte ignore the a11y warnings.

@shilman
Copy link
Member

shilman commented Oct 11, 2022

Followups:

  • Need a storybook for developing Storybook's UI
  • Need demo storybooks to link to throughout our docs
  • Need (?) a demo storybook for interaction testing (maybe -- see AccountForm)

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO!!! Let's goooooo!!!! 🚀

@shilman shilman changed the title remove official-example Examples: Remove official-storybook Oct 11, 2022
@shilman shilman merged commit 19a6e89 into next Oct 11, 2022
@shilman shilman deleted the norbert/sb-702-migrate-stories-and-delete-official branch October 11, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants