-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove angular-cli
example
#19202
Merged
tmeasday
merged 10 commits into
tom/sb-512-angular-14
from
tom/sb-606-migrate-stories-and-delete-angular-cli
Oct 10, 2022
Merged
Remove angular-cli
example
#19202
tmeasday
merged 10 commits into
tom/sb-512-angular-14
from
tom/sb-606-migrate-stories-and-delete-angular-cli
Oct 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tmeasday
force-pushed
the
tom/sb-606-migrate-stories-and-delete-angular-cli
branch
from
September 16, 2022 05:24
2a6a6fe
to
90575ba
Compare
…and-delete-angular-cli
shilman
reviewed
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- great work!
shilman
approved these changes
Oct 10, 2022
Merging this into #19181 |
tmeasday
deleted the
tom/sb-606-migrate-stories-and-delete-angular-cli
branch
October 10, 2022 11:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping on #19181
WIP
basics
,core
,legacy
andothers
.stories-frameworks-angular-basics-component-with-ng-content-ng-content-about-parent--with-component-and-args
--color
is not getting picked up as an "Input" or passed to the component it seemsstories-frameworks-angular-basics-component-with-provider-di--inputs-and-inject-dependencies-with-args
-- missingelRefStr
andisAllDeps
"methods".stories-frameworks-angular-core-decorators-theme-decorator-decorators--base
relies on theme global/toolbar exported frompreview.js
-- should we drop this -- or add a general story that checks that globals are available in decorators?What I did
angular-cli
@ngrx/store
story as we can't add a dep