-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Add angular 14 sandbox template #19181
Conversation
@tmeasday It's unfortunate that they are marked as Perhaps something like this is an option: module.exports = {
...
module: {
rules: [
{
test: /\.tsx?$/,
use: [
{
loader: 'ts-loader',
options: {
transpileOnly: true
}
}
]
}
]
}
} |
c38b060
to
297725c
Compare
…and-delete-angular-cli
import { DiComponent } from './di.component'; | ||
|
||
export default { | ||
title: 'Basics / Component / With Provider', | ||
// title: 'Basics / Component / With Provider', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the title is deactivated in order to take the one of the file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, one thing we wanted to do was to rely on autotitle so it was easier to map stories back to the files they came from. I for one have often struggled to figure out which file a failing story is from due to titles. I left the names in there commented out in case someone wanted to rename the files to better match the old titles.
Does not work after merge next into this branch
|
Ughh, bad merge sorry. |
To resolve `core-js` problems
What I did
Add template for angular 14 and template components for angular 🎉 .
Caveats
The angular template does not work out-of-the-box with
yarn bootstrap --prep
(It works fine with--core
). In particular:--no-link
(i.e. verdaccio), it has many TS errors in our code that you can remove by adding"skipLibCheck": true
to the generated.storybook/tsconfig.json
.--link
, it seems theskipLibCheck
doesn't work because it doesn't respect symlinks and thus thinks our code isn't innode_modules
(at least I think that's what going on.We are going to follow up the above -- some options are: