Addon-docs: Move DocsRenderer back to addon-docs #18708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3ff9b31. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
tmeasday
commented
Jul 14, 2022
Comment on lines
+125
to
+130
| const toJSXString = | ||
| typeof reactElementToJSXString === 'function' | ||
| ? reactElementToJSXString | ||
| : // @ts-ignore | ||
| reactElementToJSXString.default; | ||
| let string = applyBeforeRender(toJSXString(child, opts as Options), options); |
There was a problem hiding this comment.
I had to make this change to deal with an inconsistency in react-element-to-jsx-string's exports in different build contexts. I'd suggest we should fix that upstream (also maybe we should maintain that package?)
It shouldn't be necessary as a different `React` instance renders the user's component.
tmeasday
force-pushed
the
tom/sb-453-dependencies-ensure-react-dom-mdx
branch
from
7d6f3d9 to
59a2892
Compare
tmeasday
added
dependencies
maintenance
|
@shilman we might need to discuss these |
|
Add |
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Refactored
lib/blocksto remove dependencies and improved external docs so it uses theme.How to test
Run
react-tsand theexternal-docsapp