Change ArgsTable API to work with of={storyRef} and isolate channel
#18720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @ndelangen this fixes annoying errors like: ``` error - ../../lib/blocks/dist/index.js Module build failed: Error: ENOENT: no such file or directory, open '/Users/tom/GitHub/storybookjs/storybook/lib/blocks/dist/index.js' ```
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0121716. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
tmeasday
changed the title
of={storyRef} and isolate channel
|
Closing in favour of #18730 for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping on #18708
Screen.Recording.2022-07-15.at.5.02.38.pm.mov
What I did
Change
<ArgsTable>to allowof={storyRef}(which clashes withof={Component}but this will work OK. We will split it into<Controls>and<Props>soon!.Ensure events in external docs are isolated to a local channel for the
ExternalDocsContext. In theory that means you can have two isolated ones 🤷