Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade @storybook/jest in examples #18582

Merged
merged 5 commits into from
Jul 15, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jun 27, 2022

Issue: N/A

What I did

This PR:

  • Updates @storybook/jest to the latest in our examples
  • Uses new matchers feature in story examples, like .toBeInTheDocument()

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the maintenance User-facing maintenance tasks label Jun 27, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jun 27, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 93b659a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen
Copy link
Member

@yannbf

ERR! ERROR in /tmp/storybook/examples/angular-cli/src/stories/addons/interactions/addon-interactions.stories.ts(74,7):
ERR! TS2339: Property 'toBeInTheDocument' does not exist on type 'JestMatchersShape<Matchers<void, HTMLElement>, Matchers<Promise<void>, HTMLElement>>'.

@yannbf
Copy link
Member Author

yannbf commented Jul 13, 2022

Hey @ndelangen it's good now! Though there is a problem with the e2e-tests-core step and the reason is unrelated:

  • create-vite now includes vite 3.0, and the template for a react starter includes type: "module" in package.json, which then explodes in Storybook 6.5 because we don't have the esbuild-register fix there

This problem will go away once we merge future/base into next

@ndelangen ndelangen merged commit c26e897 into next Jul 15, 2022
@ndelangen ndelangen deleted the chore/upgrade-testing-lib-examples branch July 15, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants