Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade storybook/jest and storybook/testing-library in examples #17526

Closed
wants to merge 16 commits into from

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Feb 17, 2022

Issue: N/A

What I did

  • Updated @storybook/testing-library and @storybook/jest to the latest
  • Used new matchers feature in story examples, like .toBeInTheDocument()

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the maintenance User-facing maintenance tasks label Feb 17, 2022
@nx-cloud
Copy link

nx-cloud bot commented Feb 17, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0cbcd92. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf self-assigned this Feb 21, 2022
@yannbf
Copy link
Member Author

yannbf commented Feb 21, 2022

@shilman I've got no idea why the angular snapshots are changed. It's an angular attribute e.g _nghost-a-c44 (that should have never been included because we use jest-preset-angular/build/serializers/no-ng-attributes). I took the opportunity to migrate the setup because it was deprecated, although the snapshots still changed. @storybookjs/angular any help? Thanks!

@yannbf yannbf force-pushed the chore/upgrade-testing-libs branch from 3742678 to 20563b8 Compare February 25, 2022 10:58
@shilman
Copy link
Member

shilman commented Feb 28, 2022

@yannbf I've updated the PR and fixed the lockfile, but the change seems to be causing some other errors in the build. Can you please look into it?

@yannbf yannbf force-pushed the chore/upgrade-testing-libs branch from b533be5 to ee96335 Compare March 14, 2022 10:20
@yannbf yannbf removed the in progress label Apr 4, 2022
@yannbf
Copy link
Member Author

yannbf commented Jun 27, 2022

Closing this in favor of #18582

@yannbf yannbf closed this Jun 27, 2022
@stof stof deleted the chore/upgrade-testing-libs branch August 31, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants