Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in the deprecation warning for RN and Vue apps #1827

Merged
merged 1 commit into from
Sep 9, 2017

Conversation

orelmax
Copy link
Contributor

@orelmax orelmax commented Sep 9, 2017

Issue: #1268

What I did

Fixed typos

How to test

nothing to test

@codecov
Copy link

codecov bot commented Sep 9, 2017

Codecov Report

Merging #1827 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1827   +/-   ##
=======================================
  Coverage   21.32%   21.32%           
=======================================
  Files         257      257           
  Lines        5739     5739           
  Branches      688      689    +1     
=======================================
  Hits         1224     1224           
- Misses       3994     4003    +9     
+ Partials      521      512    -9
Impacted Files Coverage Δ
app/react-native/src/index.js 0% <ø> (ø) ⬆️
app/vue/src/client/index.js 0% <ø> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 51.16% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.1% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 920de11...01c65a3. Read the comment docs.

@ndelangen ndelangen merged commit f077e6a into storybookjs:master Sep 9, 2017
@ndelangen
Copy link
Member

Good catch! Thanks for fixing this @orelmax ! 👍

@ndelangen ndelangen added the bug label Sep 9, 2017
@orelmax
Copy link
Contributor Author

orelmax commented Sep 12, 2017

Thanks @ndelangen. I'd like to continue with this issue)

@orelmax orelmax deleted the fix/broken_links branch September 12, 2017 07:22
@ndelangen
Copy link
Member

Awesome! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants