Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix welcome instructions now that getstorybook does not add Button source #1358

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

formido
Copy link
Contributor

@formido formido commented Jun 26, 2017

Issue:

What I did

How to test

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we'll probably have to update the instructions now that the demo code has been refactored, but for now this is a good patch.

cc @ndelangen @usulpro @tmeasday

@tmeasday
Copy link
Member

Does this still make sense? You can't actually edit the button definition; maybe we need to change the message..

@shilman shilman changed the base branch from master to fix-welcome-message June 26, 2017 05:15
@shilman
Copy link
Member

shilman commented Jun 26, 2017

@tmeasday merging into a tmp branch, updating the message and snapshot, and will re-issue

@shilman shilman merged commit 6b87d3d into storybookjs:fix-welcome-message Jun 26, 2017
@shilman shilman changed the title Fix pointer to Button definition location Fix welcome instructions now that getstorybook does not add Button source Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants