Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed welcome instructions #1359

Merged
merged 3 commits into from
Jun 26, 2017
Merged

Fixed welcome instructions #1359

merged 3 commits into from
Jun 26, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 26, 2017

Issue: N/A

What I did

Updated the snapshot from #1358 and tweaked the instructions slightly

How to test

N/A

@shilman shilman requested a review from tmeasday June 26, 2017 05:30
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title Fix welcome message Fixed welcome instructions Jun 26, 2017
@storybookbot
Copy link
Collaborator

Fails
🚫

PR is not labeled with one of: ["cleanup","breaking","feature","bug","documentation","maintenance","greenkeeper","other"]

Generated by 🚫 dangerJS

@shilman shilman added the cleanup Minor cleanup style change that won't show up in release changelog label Jun 26, 2017
@shilman shilman merged commit 4752119 into master Jun 26, 2017
@codecov
Copy link

codecov bot commented Jun 26, 2017

Codecov Report

Merging #1359 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1359   +/-   ##
=======================================
  Coverage   14.12%   14.12%           
=======================================
  Files         201      201           
  Lines        4609     4609           
  Branches      493      506   +13     
=======================================
  Hits          651      651           
+ Misses       3547     3511   -36     
- Partials      411      447   +36
Impacted Files Coverage Δ
app/react/src/demo/Welcome.js 0% <ø> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 41.66% <0%> (ø) ⬆️
app/react/src/client/preview/reducer.js 0% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.78% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 0% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be77100...8e6df76. Read the comment docs.

@Hypnosphi Hypnosphi deleted the fix-welcome-message branch August 17, 2017 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants