Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lang attribute for frame #3065

Merged
merged 1 commit into from
Feb 23, 2018
Merged

add lang attribute for frame #3065

merged 1 commit into from
Feb 23, 2018

Conversation

danielduan
Copy link
Member

Issue: #2538 lang attribute missing for storybook menu frame

What I did

How to test

Is this testable with jest or storyshots?

Does this need a new example in the kitchen sink apps?

Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Feb 23, 2018

Codecov Report

Merging #3065 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3065   +/-   ##
=======================================
  Coverage   36.78%   36.78%           
=======================================
  Files         420      420           
  Lines        9873     9873           
  Branches      824      833    +9     
=======================================
  Hits         3632     3632           
- Misses       5772     5777    +5     
+ Partials      469      464    -5
Impacted Files Coverage Δ
addons/knobs/src/components/types/Color.js 8.1% <0%> (ø) ⬆️
...src/server/config/WatchMissingNodeModulesPlugin.js 0% <0%> (ø) ⬆️
addons/actions/src/lib/util/typeReviver.js 71.42% <0%> (ø) ⬆️
lib/core/src/client/preview/config_api.js 45.76% <0%> (ø) ⬆️
app/angular/src/server/angular-cli_config.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/WrapStory.js 61.11% <0%> (ø) ⬆️
...ents/stories_panel/stories_tree/tree_decorators.js 34.37% <0%> (ø) ⬆️
addons/knobs/src/components/types/Date/index.js 23.52% <0%> (ø) ⬆️
addons/info/src/components/makeTableComponent.js 67.46% <0%> (ø) ⬆️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b29ea...b2c11f2. Read the comment docs.

@Hypnosphi Hypnosphi added accessibility patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 23, 2018
@Hypnosphi Hypnosphi merged commit 4d4d974 into master Feb 23, 2018
@Hypnosphi Hypnosphi deleted the dd/en-us branch February 23, 2018 20:56
@Hypnosphi Hypnosphi removed the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Hypnosphi added a commit that referenced this pull request Mar 6, 2018
add lang attribute for frame
# Conflicts:
#	app/polymer/src/server/index.html.ejs
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants