fix: Add html lang attribute to iframe #7892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
ndelangen
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: related to Issue #2538 and PR #3065
What I did
htmlelement'slangattribute is missing in the coreindex.ejstemplate. This PR adds that attribute back in. This fix will improve the accessibility of the app (html elements need a lang attribute), and it will ensure components that use the CSS .hyphensproperty will display hyphenated text as intended. If you're curious, here's some links for learning more about why pages need the lang attribute and why the lang attribute is needed for CSS hyphenation.How to test
If your answer is yes to any of these, please make sure to include it in your PR.