Core: Fix configFilename containing backticks
#9960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In windows the path sep is '\' which will lead to weird stuff like: chromaui/learnstorybook.com#284
shilman
added
bug
core
patch:yes
shilman
changed the title
configFilename containing backticksconfigFilename containing backticks
shilman
removed
the
patch:yes
|
@tmeasday this looks like 6.0 code. does it also need to get patched to 5.3? |
|
No, was just a fix to the parameter refactor stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9937
In windows the path sep is
\which will lead to weird stuff like: chromaui/learnstorybook.com#284