Fix: Add downlevel dts #9902
Merged
Fix: Add downlevel dts #9902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetanmaisse
requested review from
aaronmcadam,
alexandrebodin,
alterx,
CodeByAlex,
dangreenisrael,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh,
ndelangen,
renaudtertrais,
saponifi3d,
shilman,
stijnkoopal,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
ndelangen
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Cherry-picks of #9847 to fix #9463 on
nextWhat I did
Just cherry-picked the 4 commits of #9847 and fix the conflicts to apply them to
next.See #9847 for details.
TLDR;
While there are incompatible declaration outputs between TypeScript 3.7+ and TS3.5, there is a workaround to use the latest TypeScript version while still maintaining compatible d.ts files. This is accomplished by using
downlevel-dtsto generate alternative typings for users on a certain version of TypeScript.In this PR, any users who are on TS3.5 and below, TypeScript will automatically look at the package.json for a field called
typesVersionsand utilize the typings in that folder via a mapping.