Typescript: Improve @storybook/ui types #9820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmeasday @shilman @kroeder @gaetanmaisse Would really love your input & review. |
| @@ -44,13 +44,11 @@ export interface Addon { | |||
| disabled?: boolean; | |||
| hidden?: boolean; | |||
| } | |||
| export interface Collection { | |||
| [key: string]: Addon; | |||
| export interface Collection<T = Addon> { | |||
There was a problem hiding this comment.
Maybe to rename? Because Collection makes more think to an array/list than to a map/dictionary
There was a problem hiding this comment.
It's exported. If we want to change the name, I'd like to do that in a separate PR.
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: in prep for #9210 I needed to clean up the code in lib/ui
What I did
I did a bunch of refactoring to make the lib/ui code simpler to reason about.
Functionality wise, there should be 0 change