Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Paddings addon to addon gallery #9647

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Add Paddings addon to addon gallery #9647

merged 1 commit into from
Jan 28, 2020

Conversation

rbardini
Copy link
Contributor

What I did

Add Paddings addon to the Community Addons section in addon gallery.

@vercel
Copy link

vercel bot commented Jan 27, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

@ndelangen
Copy link
Member

hey @rbardini this looks cool, and very much related to a change I did for 6.0.0 a few days ago here:
#9229

This has yet to be documented. Perhaps you'd like help us out with that?

The addon looks polished, definitely worth an add to the list!

@ndelangen ndelangen added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 27, 2020
@ndelangen ndelangen added this to the 5.3.x milestone Jan 27, 2020
@ndelangen ndelangen merged commit 45755b3 into storybookjs:next Jan 28, 2020
@rbardini rbardini deleted the add-paddings-addon branch January 28, 2020 19:11
@rbardini
Copy link
Contributor Author

Thanks @ndelangen!

I wasn't aware something related was being discussed already. Good to know there may be demand for an addon like this. I'll need to do some changes to make it work well with the layout parameter though, as the addon pads the iframe element instead of the preview document.

Meanwhile, I can give documentation a try. Any suggestions where this should be placed? I'm thinking of a Layout parameter section under Configurations.

@ndelangen
Copy link
Member

@rbardini we can always move the page, your suggestion sounds good to me!

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 2, 2020
shilman pushed a commit that referenced this pull request Feb 2, 2020
Add Paddings addon to addon gallery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants