-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webcomponents): make types play nicely with lit-element #9557
Conversation
Before this change, returning html`<sometag>...</sometag>` from `storiesOf(...).add` would result in the following error: Type 'TemplateResult' is not assignable to type 'StoryFnHtmlReturnType'
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/lnt7vsofn |
I think we need a eslint-ignore-next-line rule for:
|
@ndelangen do you want me to amend the pull request and add this? |
I read: "would you please amend the PR", so I went ahead and did it. Thanks for the PR @urish! |
Even better :-) p.s. you can see it in action here: https://elements.wokwi.com/ |
fix(webcomponents): make types play nicely with lit-element
also remove patch-package, as the following PR was merged: storybookjs/storybook#9557
What I did
Before this change, returning html
<sometag>...</sometag>
fromstoriesOf(...).add
would result in the following error: Type 'TemplateResult' is not assignable to type 'StoryFnHtmlReturnType'