Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Angular button example story #9540

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Fixed Angular button example story #9540

merged 1 commit into from
Jan 20, 2020

Conversation

devtronic
Copy link
Contributor

Issue:
The button example story in Angular is broken. The text isn't displayed since the property name was renamed in 24ec9d3.

What I did

Made the property name lowercase.

How to test

  • Is this testable with Jest or Chromatic screenshots? Idk.
  • Does this need a new example in the kitchen sink apps? Idk.
  • Does this need an update to the documentation? No

The property in the Angular component is lowercase. Without this change, the button example story wont work properly.
(The button text isn't rendered)
@vercel
Copy link

vercel bot commented Jan 19, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/ndqztnot7
✅ Preview: https://monorepo-git-fork-devtronic-fix-angular-button-example.storybook.now.sh

@shilman shilman added angular bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 20, 2020
@ndelangen
Copy link
Member

Thank you @devtronic !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants