Clean usage of @types/webpack-env dep in all packages
#9536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/fmguac8k9 |
gaetanmaisse
force-pushed
the
fix-webpack-env
branch
from
5b34f93 to
b62b8fc
Compare
gaetanmaisse
added
patch:yes
gaetanmaisse
force-pushed
the
fix-webpack-env
branch
from
b62b8fc to
e17e05a
Compare
gaetanmaisse
requested review from
alexandrebodin,
alterx,
CodeByAlex,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
ndelangen,
renaudtertrais,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
- `@types/webpack-env` must be defined as `dependencies` in packages that export a type/function using typings from `@types/webpack-env` (it is often `NodeModule`). In that case `/// <reference types="webpack-env" />` is present in some files of the `dist` folder of the lib. Example: `lib/client-api`. - `@types/webpack-env` must be defined as `devDependencies` in packages that use its typings internally but does not expose anything related to it. Many addons need the type because they use `module.hot` function. Example: `addons/a11y` - `webpack-env` should be removed from "compilerOptions.types" key of `tsconfig.json` of packages that don't need it. I also bump `@types/webpack-env` to ^1.15.0 to have the same version all across the monorepo
gaetanmaisse
force-pushed
the
fix-webpack-env
branch
from
e17e05a to
36ee762
Compare
ndelangen
approved these changes
Jan 20, 2020
shilman
added
the
patch:done
This was referenced Feb 12, 2020
This was referenced Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7855
What I did
Clean usage of
@types/webpack-envdep in all packages:@types/webpack-envmust be defined asdependenciesin packages that export a type/function using typings from@types/webpack-env(it is oftenNodeModule). In that case/// <reference types="webpack-env" />is present in some files of thedistfolder of the lib. Example:lib/client-api.@types/webpack-envmust be defined asdevDependenciesin packages that use its typings internally but does not expose anything related to it. Many addons need the types because they usemodule.hotfunction. Example:addons/a11ywebpack-envshould be removed from "compilerOptions.types" key oftsconfig.jsonof packages that don't need it.I also bump
@types/webpack-envto^1.15.0to have the same version all across the monorepo.