Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update addon storyshot puppeteer doc #9526

Merged
merged 2 commits into from
Jan 18, 2020
Merged

Update addon storyshot puppeteer doc #9526

merged 2 commits into from
Jan 18, 2020

Conversation

gaetanmaisse
Copy link
Member

@gaetanmaisse gaetanmaisse commented Jan 18, 2020 •
edited
Loading

Issue: #9517

puppeteer was moved to optional peer dependency in #8925 but the documentation wasn't updated accordingly.

What I did

Update docs:

  • add a section about external puppeteer in MIGRATION.md
  • add a warning to emphasize the fact that as of SB 5.3 puppeteer must be added to the project dep directly

@vercel
Copy link

vercel bot commented Jan 18, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/51mp1q68x
✅ Preview: https://monorepo-git-update-addon-storyshot-puppeteer-doc.storybook.now.sh

@gaetanmaisse gaetanmaisse force-pushed the update-addon-storyshot-puppeteer-doc branch from 0591c9a to 792064b Compare January 18, 2020 07:40
@gaetanmaisse gaetanmaisse marked this pull request as ready for review January 18, 2020 07:43
@gaetanmaisse gaetanmaisse mentioned this pull request Jan 18, 2020
Closed
shilman
shilman approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME 💯

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 18, 2020
@shilman shilman added this to the 5.3.x milestone Jan 18, 2020
@shilman shilman merged commit 4a5508d into next Jan 18, 2020
@shilman shilman deleted the update-addon-storyshot-puppeteer-doc branch January 18, 2020 10:30
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 21, 2020
@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees
No one assigned
Labels
addon: storyshots documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@gaetanmaisse @shilman