Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix addon/preset detection for local addons #9485

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Core: Fix addon/preset detection for local addons #9485

merged 2 commits into from
Jan 16, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 16, 2020

Issue: #9343

What I did

Handle local addons packages, based on great detective work by @RuneKR in #9454

How to test

See updated test cases

@vercel
Copy link

vercel bot commented Jan 16, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/9v2uvhiqv
✅ Preview: https://monorepo-git-9343-fix-relative-path-addons.storybook.now.sh

@shilman shilman added bug core patch:yes Bugfix & documentation PR that need to be picked to main branch presets labels Jan 16, 2020
@shilman shilman added this to the 5.3.x milestone Jan 16, 2020
@shilman shilman mentioned this pull request Jan 16, 2020
Merged
tmeasday
tmeasday approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Apart from inaccurate comment

lib/core/src/server/presets.js Outdated Show resolved Hide resolved
@shilman shilman mentioned this pull request Jan 16, 2020
Closed
@shilman shilman merged commit 064f52c into next Jan 16, 2020
@shilman shilman deleted the 9343-fix-relative-path-addons branch January 16, 2020 06:05
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 16, 2020
This was referenced Jan 16, 2020
Closed
Closed
This was referenced Feb 12, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 24, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees
No one assigned
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch presets
Projects
None yet
Milestone
5.3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday