Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emphasize the happy path in storyshots README. #9426

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Emphasize the happy path in storyshots README. #9426

merged 1 commit into from
Jan 14, 2020

Conversation

tmeasday
Copy link
Member

Issue:

You needed to read a bunch of no-longer highly relevant require.context guff in order to get to the actual configuration of storyshots

What I did

Fixed it.

@vercel
Copy link

vercel bot commented Jan 14, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/l7dcbcsw5
✅ Preview: https://monorepo-git-tmeasday-patch-1.storybook.now.sh

@github-actions
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against cc5fe87

shilman
shilman requested changes Jan 14, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👏

shilman
shilman approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👏

@shilman shilman merged commit e157446 into master Jan 14, 2020
@shilman shilman deleted the tmeasday-patch-1 branch January 14, 2020 08:40
@shilman shilman added this to the 5.3.x milestone Jan 14, 2020
@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@thomasbertet thomasbertet Awaiting requested review from thomasbertet thomasbertet is a code owner

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
5.3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman