Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toolbar documentation #9377

Merged
merged 1 commit into from
Jan 11, 2020
Merged

Conversation

aromanarguello
Copy link
Contributor

@aromanarguello aromanarguello commented Jan 10, 2020

Issue: 6985

Added documentation about the toolbar + how to add a custom addon to the toolbar. LMK if this needs to be added elsewhere :)

When I ran the tests in the next branch I see this test failing. Not sure why this is failing for me locally. Could I get some feedback on it?
Screen Shot 2020-01-09 at 11 29 06 PM

@vercel
Copy link

vercel bot commented Jan 10, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/jbwx7ubq6
✅ Preview: https://monorepo-git-fork-aromanarguello-toolbarguid.storybook.now.sh

@ndelangen
Copy link
Member

This is awesome @aromanarguello !

@ndelangen ndelangen added this to the 5.3.0 milestone Jan 10, 2020
@ndelangen
Copy link
Member

The tests seem to pass on CI, and documentation changes really shouldn't impact tests at all. So I think it's fine.

@aromanarguello
Copy link
Contributor Author

Thanks, glad it is helpful 😄 @ndelangen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants