Addon-docs: Fix scroll behavior on page navigation #9331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/kxhju6fsx |
patricklafrance
commented
Jan 5, 2020
| export const Meta: FunctionComponent<MetaProps> = props => null; | ||
| export const Meta: FC<MetaProps> = () => { | ||
| const params = new URL(document.location).searchParams; | ||
| const isDocs = params.get('viewMode') === 'docs'; |
There was a problem hiding this comment.
Is there a better way to do this @shilman ?
shilman
changed the title
shilman
changed the title
shilman
approved these changes
Jan 6, 2020
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8914
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.