-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge pull request #9280 from weyert/bugfixes/fix-simplify-issue #9280
Conversation
A small fix to disable the simplify-feature of the babel's minify plugin as it stops the compilation of the storybook static build.
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/g7lv4wj2a |
How did my change cause a change in package-lock.json as suggested? |
Thanks for kicking this off @weyert!! I don't see any change in Since this is a core change, I want to get some feedback on it from members of our core team. @Hypnosphi @tmeasday any thoughts? |
LGTM, here's the docs for reference https://github.com/babel/minify/tree/master/packages/babel-plugin-minify-simplify @shilman please verify that the case from #9077 (comment) works with this change before closing #9077 |
@Hypnosphi @weyert did not fix #9077 so leaving that open |
Issue: #9261
A small fix to disable the simplify-feature of the babel's minify plugin as it stops the compilation of the storybook static build.
What I did
I have added the
simplify: false
-configuration to thebabel.js
-fileHow to test
No
No
I am not sure