-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for @storybook/server #9250
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/527hm46c9 |
Amazing progress @bostanio! I'm guessing this will take some back and forth to get right, so I'll start things off:
|
@shilman Working on an example. Exploring the simplest 'app' to use as the backend. I'm guessing its express. Can certainly change the |
I'd also be open to a third |
OK I'll go with that. |
Added a first pass at the example app. Would love some advice on how we might structure that example and how much of a 'kitchen sink' we want it to be. |
f5b8335
to
7145e09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so cool!
71877bb
to
cb4c6d8
Compare
cb4c6d8
to
bbe0384
Compare
@jonspalmer there are still two unresolved comments on that PR that we need to sort out:
Also a change to |
@ndelangen yeah he filed some follow-up issues |
@ndelangen this was a bit confusing but @jonspalmer answered my questions on the other PR |
Issue: Added a new "server" framework
What I did
Added @storybook/server based on @storybook/html.
What's new is that the
configure
method takes a new fetchHtml argument that is responsible for fetching the html from the story.How to test
I will followup with a kitchen sink example.
Usage is something like this:
Open Questions/Issues