Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Include ember files in addon-docs publish #9230

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

meirish
Copy link
Contributor

@meirish meirish commented Dec 23, 2019

Issue:
Testing out ember's new props table integration locally, I ran into this error: Can't resolve '@storybook/addon-docs/ember'. This was my first time running it from registry-installed packages, previously I'd only used yarn link.

What I did

I found that the relevant files weren't included in files in package.json, so I added them.

How to test

I tested this locally with the local registry script and a local ember app.

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Dec 23, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/cknw5i8qv
🌍 Preview: https://monorepo-git-b-addon-docs-ember-files.storybook.now.sh

@meirish meirish added this to the 5.3.0 milestone Dec 24, 2019
@shilman shilman changed the title Addon-docs: include ember files when publishing addon-docs Addon-docs: Include ember files in addon-docs publish Dec 24, 2019
@shilman shilman merged commit 2a8c04f into next Dec 24, 2019
@ndelangen ndelangen deleted the b-addon-docs-ember-files branch July 16, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants