PR review policy #923
Merged
PR review policy #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick pass at reviewer policy after short chat with @tmeasday
tmeasday
previously requested changes
Apr 20, 2017
CONTRIBUTING.md
Outdated
| @@ -56,9 +56,9 @@ Before you submit a new PR, make you to run `npm test`. Do not submit a PR if te | |||
|
|
|||
| ### Reviewing PRs | |||
|
|
|||
| **As a PR submitter**, you should reference the issue if there is one, include a short description of what you contributed and, if it is a code change, instructions for how to manually test out the change. This is informally enforced by our [PR template](https://github.com/storybooks/storybook/blob/master/.github/PULL_REQUEST_TEMPLATE.md). | |||
| **As a PR submitter**, you should reference the issue if there is one, include a short description of what you contributed and, if it is a code change, instructions for how to manually test out the change. This is informally enforced by our [PR template](https://github.com/storybooks/storybook/blob/master/.github/PULL_REQUEST_TEMPLATE.md). If you have merge rights and the changes are trivial, feel free to force merge without a review. | |||
There was a problem hiding this comment.
This isn't quite what I meant.
What I meant was:
If your PR is reviewed as only needing trivial changes (e.g. small typos etc), and you have commit access, then you can merge the PR after making those changes.
ndelangen
approved these changes
Apr 20, 2017
This was referenced Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Quick pass at reviewer policy after short chat with @tmeasday
Improvements welcome! Since this is a policy change, I'll wait for two approving reviews before I merge.
How to test
N/A