Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README about @storybook/react typescript part #9227

Merged
merged 1 commit into from
Dec 24, 2019
Merged

Update README about @storybook/react typescript part #9227

merged 1 commit into from
Dec 24, 2019

Conversation

CPatchane
Copy link
Contributor

@CPatchane CPatchane commented Dec 23, 2019 •
edited
Loading

What I did

Update documentation about @storybook/react types usage with Typescript since:
Screenshot 2019-12-23 at 16 00 49

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? Yes

If you think the phrasing is wrong or can be better, I can change :)

@vercel
Copy link

vercel bot commented Dec 23, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/a70z2le2p
🌍 Preview: https://monorepo-git-fork-cpatchane-fix-reacttypesdoc.storybook.now.sh

@vercel vercel bot temporarily deployed to staging December 23, 2019 15:17 Inactive
@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 24, 2019
@shilman
Copy link
Member

shilman commented Dec 24, 2019

Thanks @CPatchane !!!

shilman
shilman approved these changes Dec 24, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@shilman shilman merged commit ab694d5 into storybookjs:next Dec 24, 2019
@CPatchane CPatchane deleted the fix/react_types_doc branch December 24, 2019 09:05
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees
No one assigned
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CPatchane @shilman