CLI: Make template stories glob more permissive
#9224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/heiwlklwt |
shilman
changed the title
stories glob more permissive
ghengeveld
approved these changes
Dec 23, 2019
|
Maybe we should not create a |
|
@ghengeveld Yeah I don't like |
|
Do we dare making assumptions about where users put their components? |
|
Well perhaps in case of a specific generator (CRA, Vue, Angular) we can make an educated guess. Anyway it's beyond the scope of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
In Storybook we recommend users to colocate their stories with their components. However, in our CLI templates, we generate a stories glob which points to
src/storiesdirectory. As soon as users start adding stories next to their components, those stories won't show up, as their components are probably not in thesrc/storiesdirectory. This PR updates the glob in all the templates to help minimize user confusion (with a hopefully small perf cost, unless they are working in a massive repo).This is in response to a Slack support request from a user who had exactly this problem.
How to test
Verify CLI test run passes in CI