-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TS strict mode in a11y addon sources #9180
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/ko1hjbvxn |
It looks like this component and related color map are not used anymore since bdbd153
Activate noUnusedLocals and remove all unneeded imports
Activate strictFunctionTypes and fix TS errors related to it
Activate strictNullChecks and fix TS errors related to it
Activate noUnusedParameters and fix TS errors related to it
47bc0a7
to
daec5a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this relate to #8883?
@ndelangen I just take a look at #8883, there will be only minor conflicts because this PR focus on refactoring/cleaning some TS (strict mode) issues and not deeply modifying how the addon works. #8883 can be merged ( |
What I did
Use TS strict mode in a11y addon sources. But why?
strict
mode is included in the defaulttsconfig.json
generated by tsc CLItsconfig.json
noUnusedLocals
put in light the fact that some variables were not used for at least 8 months but still there and still requiring maintenance.How to test