Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storyshots: Escape Windows fileNames #9061

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Storyshots: Escape Windows fileNames #9061

merged 1 commit into from
Dec 5, 2019

Conversation

Hypnosphi
Copy link
Member

Issue: multisnapshotWithOptions + CSF doesn't work on Windows

@Hypnosphi
Storyshots: escape Windows fileNames
f623cd1 
Issue: `multisnapshotWithOptions` + CSF doesn't work on Windows
@vercel
Copy link

vercel bot commented Dec 4, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/ifzr16klg
🌍 Preview: https://monorepo-git-hypnosphi-patch-1.storybook.now.sh

@Hypnosphi Hypnosphi added addon: storyshots bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 4, 2019
@Hypnosphi Hypnosphi requested a review from shilman December 4, 2019 18:43
shilman
shilman approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title Storyshots: escape Windows fileNames Storyshots: Escape Windows fileNames Dec 5, 2019
@shilman shilman merged commit 1f4d7a1 into next Dec 5, 2019
@shilman shilman deleted the Hypnosphi-patch-1 branch December 5, 2019 02:25
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 16, 2020
@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees
No one assigned
Labels
addon: storyshots bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hypnosphi @shilman