-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: MDX Linking #9051
Addon-docs: MDX Linking #9051
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). |
@patricklafrance this is INCREDIBLE! 💯💯💯 One small request is to fix the linking behavior. Storybook vs Github: |
@shilman done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THIS IS SO RAD
Is there any setting for this feature? Where can I find the sample code snippet of this feature? My Headings don't have ids, and I cant find how to fix it. Thanks |
Perhaps I'm missing something, but this doesn't appear to work as expected in the official docs - https://next--storybookjs.netlify.app/official-storybook/?path=/docs/addons-docs-markdown-docs--page Clicking a heading just takes me to a blank page because it tries to go to the root path |
there's an open issue with a PR #16918 |
Issue: #8184
What I did
Improved MDX linking:
How to test
It can be tested with the
?path=/docs/addons-docs-markdown-docs--page
story of the official storybook.