Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Demo url for react-native-web #8893

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Conversation

kerbe
Copy link
Contributor

@kerbe kerbe commented Nov 20, 2019

React Native for Web seems to have changed it's documentation style and url.
Old url results 404 error, so this update points to right place.
Fixed in all places in codebase where link seems to be active..

Issue:

What I did

Searched whole codebase to change old url http://necolas.github.io/react-native-web/storybook/ into new working url https://necolas.github.io/react-native-web/docs/

How to test

Click the links.

React Native for Web seems to have changed it's documentation style and url.
Old url results 404 error, so this update points to right place.
Fixed in all places in codebase where link seems to be active..
@vercel
Copy link

vercel bot commented Nov 20, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/jx3sw5nzi
🌍 Preview: https://monorepo-git-fork-kerbe-patch-docs.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!!

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Nov 20, 2019
@shilman shilman merged commit 87e705d into storybookjs:next Nov 20, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 30, 2019
shilman added a commit that referenced this pull request Nov 30, 2019
Correct Demo url for react-native-web
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants