UI: Store layout state in sessionStorage #8786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/el5ygmmhs |
ghengeveld
commented
Nov 11, 2019
| layout: { | ||
| ...state.layout, | ||
| panelPosition: position, | ||
| panelPosition: state.layout.panelPosition === 'right' ? 'bottom' : 'right', |
There was a problem hiding this comment.
This is just GitHub rendering a weird diff.
ndelangen
approved these changes
Nov 11, 2019
shilman
added
the
patch:yes
shilman
changed the title
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Nov 30, 2019
UI: Store layout state in sessionStorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This adds
{ persistence: 'session' }to allstore.setStatecalls inlayout.ts. This will make sure panel visibility and other layout settings are retained between page reloads.How to test
Toggle one of the layout settings (fullscreen, nav, addons, toolbar) and reload the page. Notice your settings will be retained.