Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @babel/runtime to workspace #8774

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Add @babel/runtime to workspace #8774

merged 1 commit into from
Nov 9, 2019

Conversation

Hypnosphi
Copy link
Member

@ndelangen has added transform-runtime for tests, but we only depend on @babel/runtime through other packages like @emotion/core which is mostly a coincidence.

@vercel
Copy link

vercel bot commented Nov 9, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/i6fyi19p4
🌍 Preview: https://monorepo-git-add-babel-runtime.storybook.now.sh

@Hypnosphi Hypnosphi requested a review from ndelangen November 9, 2019 14:22
@Hypnosphi Hypnosphi added maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch labels Nov 9, 2019
shilman
shilman approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hypnosphi Hypnosphi merged commit be32fad into next Nov 9, 2019
@Hypnosphi Hypnosphi deleted the add-babel-runtime branch November 9, 2019 15:01
Hypnosphi added a commit that referenced this pull request Nov 9, 2019
@Hypnosphi
Merge pull request #8774 from storybookjs/add-babel-runtime
24ecf60 
Add @babel/runtime to workspace
# Conflicts:
#	yarn.lock
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 2, 2019
@shilman
Copy link
Member

shilman commented Dec 2, 2019

@Hypnosphi when i try to patch this over to master it looks like the changes are already there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hypnosphi @shilman