Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Knobs documentation to CSF #8737

Merged
merged 3 commits into from
Nov 7, 2019
Merged

Conversation

pierroberto
Copy link
Contributor

Issue:

What I did

I fixed some typos in the README and I did a rewrite of the React example in the documentation. According the documentation, Component Story Format (CSF) are the way recommended in order to write a story, therefore I migrated storiesOf in favour of the CSF.

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

@vercel
Copy link

vercel bot commented Nov 6, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/qpb4zc8gh
🌍 Preview: https://monorepo-git-fork-pierroberto-knob-doc.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your fix!!! 🙏

@shilman shilman added addon: knobs documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Nov 7, 2019
@shilman shilman changed the title Knobs documentation Move Knobs documentation to CSF Nov 7, 2019
@shilman shilman merged commit 6f85d48 into storybookjs:next Nov 7, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 9, 2019
shilman added a commit that referenced this pull request Nov 9, 2019
Move Knobs documentation to CSF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: knobs documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants