Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native: On Device Knobs Groups Fix #8694

Merged
merged 2 commits into from
Nov 4, 2019

Conversation

Gongreg
Copy link
Member

@Gongreg Gongreg commented Nov 3, 2019

Currently if all knobs have a group, we will display no knobs text instead of grouped knobs. This fixes it.

Issue: N/A

@vercel
Copy link

vercel bot commented Nov 3, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/1t9a8u82t
🌍 Preview: https://monorepo-git-addon-knobs-properly-support-groups.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit bb1c4d4 into next Nov 4, 2019
@shilman shilman deleted the addon-knobs-properly-support-groups branch November 4, 2019 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants