Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native: Fix on-device-notes #8692

Merged
merged 1 commit into from
Nov 4, 2019
Merged

React Native: Fix on-device-notes #8692

merged 1 commit into from
Nov 4, 2019

Conversation

Gongreg
Copy link
Member

@Gongreg Gongreg commented Nov 3, 2019

Issue: #7606

Notes addon is not using state anymore, since creating event listener happens only after initial story is rendered. By using api we avoid that.

… happens only after initial story is rendered. By using api we avoid that.
@vercel
Copy link

vercel bot commented Nov 3, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/a7z9crn9w
🌍 Preview: https://monorepo-git-notes-fix.storybook.now.sh

@shilman shilman changed the title React Native: On Device Notes React Native: Fix on-device-notes Nov 4, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

@shilman shilman merged commit e924cc5 into next Nov 4, 2019
@shilman shilman deleted the notes-fix branch November 4, 2019 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants