React-native: Fix event listening for story navigation #8690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry rendered is called when switching tabs.
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/lnafdgqg7 |
shilman
reviewed
Nov 3, 2019
| @@ -50,6 +50,8 @@ export default class ActionLogger extends Component<ActionLoggerProps, ActionLog | |||
| }; | |||
|
|
|||
| addAction = (action: ActionDisplay) => { | |||
| console.warn('called!!'); | |||
shilman
changed the title
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6471
What I did
Addons-ondevice-actions was completely broken (never showing any actions), so I changed the event to proper one. The issue #6471 still persists, but at least we can avoid it by not passing react events to it directy by doing.