Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Revert webpack rebuild changes in node_modules #8657

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 31, 2019

Issue: #8529

Reverts #6265

Confirmed that this solves the perf issue in development. Will merge & release to get user confirmation.

@vercel
Copy link

vercel bot commented Oct 31, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/2wybjjptr
🌍 Preview: https://monorepo-git-revert-6265-fixwebpackwatchnodemodules.storybook.now.sh

@shilman shilman added configuration babel / webpack core performance issue bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 31, 2019
@shilman shilman added this to the 5.2.x milestone Oct 31, 2019
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@shilman shilman merged commit a7748df into next Nov 1, 2019
@shilman shilman deleted the revert-6265-fix_webpack_watch_node_modules branch November 1, 2019 01:44
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 9, 2019
shilman added a commit that referenced this pull request Nov 9, 2019
Core: Revert webpack rebuild changes in node_modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug configuration babel / webpack core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch performance issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants