-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: Fix layout of Preview container #8628
Conversation
Make sure that the Preview container has a max width of 100% of its parent so that stories it contains do not cause it to expand horizontally.
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/gnzndivi3 |
Hi @necolas - thanks for putting this together!
You can see the official storybook on You can also run it locally on your fork:
Would you mind overwriting my commit with a story that exercises this change & shows how it improves the layout? I'll verify the before & after. Thanks so much for your patience & contribution! |
@shilman WDYT? |
You can see the issue here: http://necolas.github.io/react-native-web/docs/?path=/docs/components-scrollview--horizontal |
…ced component to allow customization
…be able to scroll
…n isn't reset (but vertical is)
@shilman can this PR receive your approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks @necolas and @ndelangen !!!
Fix layout of Preview container
Issue: #8377
The Preview component doesn't always contain its content. Make sure that the Preview container has a max width of 100% of its parent so that stories it contains do not cause it to expand horizontally.
What I did
Edited some styles so the preview container cannot exceed 100% of its parent width
How to test
I don't know if this is something you'd include in your tests.