Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Angular DocsPage props table #8621

Merged
merged 15 commits into from
Nov 1, 2019
Merged

Addon-docs: Angular DocsPage props table #8621

merged 15 commits into from
Nov 1, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 29, 2019 •
edited
Loading

Issue: #6664

App_Component_-_Component_With_Separate_Template_⋅_Storybook

What I did

  • Load props table
  • POC of properties, methods, inputs, outputs
  • Load description
  • Add example
  • Made prop row description markdown
  • Refine with @kroeder
    • properties
    • methods => need signature, e.g. (x: number, y: string | number) => number
    • inputs
    • outputs
  • Refactor into addon

How to test

cd examples/angular-cli
yarn storybook

@shilman shilman added this to the 5.3.0 milestone Oct 29, 2019
@vercel
Copy link

vercel bot commented Oct 29, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/bk8uoocqm
🌍 Preview: https://storybookjs.now.sh

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2019

Fails
🚫 PR is marked with "do not merge" label.

Generated by 🚫 dangerJS against c3d70bf

@shilman shilman changed the title Addon-docs: Angular DocsPage compodoc WIP Addon-docs: Angular DocsPage props table Nov 1, 2019
@shilman shilman requested a review from kroeder November 1, 2019 11:36
@vercel vercel bot temporarily deployed to staging November 1, 2019 15:56 Inactive
@vercel vercel bot temporarily deployed to staging November 1, 2019 16:02 Inactive
@kroeder
Copy link
Member

kroeder commented Nov 1, 2019

LGTM for a first version

@shilman shilman merged commit dc781f6 into next Nov 1, 2019
@shilman shilman deleted the 6664-angular-docs-page branch November 1, 2019 17:26
@shilman shilman mentioned this pull request Nov 1, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroeder kroeder kroeder approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees
No one assigned
Labels
addon: docs angular feature request
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @kroeder