Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD a step in circleci to upload storybook for angular #8477

Merged
merged 2 commits into from
Oct 18, 2019
Merged

ADD a step in circleci to upload storybook for angular #8477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dd074f
ADD a step in circleci to upload storybook for angular
ndelangen Oct 18, 2019
d2ac2ec
remove unnecessary node-sass install
ndelangen Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,12 @@ jobs:
- attach_workspace:
at: .
- run:
name: Run chromatic on the pre-built storybook
command: yarn chromatic
name: Run chromatic on the pre-built official example
command: yarn chromatic --storybook-build-dir="built-storybooks/official-storybook" --exit-zero-on-changes --app-code="ab7m45tp9p"
- run:
name: Run chromatic on the pre-built angular example
command: yarn chromatic --storybook-build-dir="built-storybooks/angular-cli" --exit-zero-on-changes --app-code="tl92yzsj6w"

packtracker:
<<: *defaults
steps:
Expand Down
2 changes: 1 addition & 1 deletion examples/angular-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "MIT",
"scripts": {
"build": "ng build",
"prebuild-storybook": "npm run storybook:prebuild && cd ../.. && yarn add node-sass -W -s && cd examples/angular-cli",
"prebuild-storybook": "npm run storybook:prebuild",
"build-storybook": "build-storybook -s src/assets",
"e2e": "ng e2e",
"ng": "ng",
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
"build-storybooks": "cross-env STORYBOOK_DISPLAY_WARNING=true DISPLAY_WARNING=true ./scripts/build-storybooks.js",
"changelog": "pr-log --sloppy --cherry-pick",
"changelog:next": "pr-log --sloppy --since-prerelease",
"chromatic": "chromatic --storybook-build-dir=\"built-storybooks/official-storybook\" --exit-zero-on-changes --app-code=\"ab7m45tp9p\"",
"coverage": "codecov",
"danger": "danger",
"dev": "concurrently --kill-others \"yarn dev:tsc\" \"yarn dev:babel\"",
Expand Down