UI: Remove emotion from NoDocs.js #8454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
added
bug
react
patch:yes
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/ek6hej8eb |
shilman
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Thanks for the fix @ndelangen! Any idea how to prevent this from happening again?
shilman
changed the title
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Oct 22, 2019
UI: Remove emotion from NoDocs.js
This was referenced Oct 30, 2019
Merged
[Snyk] Upgrade @storybook/addon-actions from 5.2.4 to 5.2.5
GrabarzUndPartner/gp-vue-boilerplate#286
Closed
Merged
Should we add a test while building to check whether error below exist? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8284
What I did
I REMOVED the usage of emotion in the places where it's not allowed