Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDX: Better ergonomics for documenting CSF #8312

Merged
merged 6 commits into from
Oct 8, 2019
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 7, 2019

Issue: #8311

What I did

  • Added imported story function support to MDX
  • Improved MDX documentation of CSF

How to test

See included examples & snapshot tests

@vercel
Copy link

vercel bot commented Oct 7, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-8311-mdx-docs-for-csf.storybook.now.sh

@shilman shilman requested a review from tmeasday October 7, 2019 08:11
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things

addons/docs/docs/recipes.md Show resolved Hide resolved
addons/docs/docs/recipes.md Outdated Show resolved Hide resolved
addons/docs/docs/recipes.md Show resolved Hide resolved
addons/docs/docs/recipes.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to staging October 7, 2019 10:28 Inactive
@shilman
Copy link
Member Author

shilman commented Oct 7, 2019

@tmeasday fixed

@shilman shilman added this to the 5.3.0 milestone Oct 8, 2019
@shilman shilman merged commit 7d0123b into next Oct 8, 2019
@shilman shilman deleted the 8311-mdx-docs-for-csf branch October 8, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants